Issue 1761002: Asynchronous TableManager::recover

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1761002: Asynchronous TableManager::recover

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by yilongl

Modified:
8 years, 8 months ago

Reviewers:
ouster

Visibility:
Public.

More Reviews

Description

Asynchronous TableManager::recover

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+399 lines, -172 lines)			Patch
M	src/TableManager.h	View	6 chunks	+45 lines, -4 lines	0 comments	Download
M	src/TableManager.cc	View	29 chunks	+311 lines, -146 lines	0 comments	Download
M	src/TableManagerTest.cc	View	21 chunks	+43 lines, -22 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

yilongl

8 years, 8 months ago (2016-03-20 02:37:04 UTC) #1

I haven't spend time in writing unit tests for the new functions. I figure it's
better I postpone it after our next meeting.

commit 90afbe857342e6bf4e6d9791cddafaf840430f57
Author: yilongl <yilongl@cs.stanford.edu>
Date:   Sat Mar 19 19:12:38 2016 -0700

    Fix deadlock in CoordinatorService::init
    
    Made TableManager::recover asynchronous to avoid deadlock during coordinator
    service startup phase.
    RAM-572 #close

Expand All Messages | Collapse All Messages