Issue 211001: Proofread

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 211001: Proofread (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by john.ousterhout

Modified:
6 years, 3 months ago

Reviewers:

Visibility:
Public.

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+683 lines, -680 lines)			Patch
M	src/BackupService.h	View	1 chunk	+22 lines, -22 lines	0 comments	Download
M	src/BackupService.cc	View	14 chunks	+59 lines, -59 lines	0 comments	Download
M	src/BackupServiceTest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/BindTransport.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/CoordinatorService.h	View	1 chunk	+43 lines, -43 lines	0 comments	Download
M	src/CoordinatorService.cc	View	19 chunks	+120 lines, -120 lines	0 comments	Download
M	src/CoordinatorServiceTest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/FailureDetector.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/FastTransportTest.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/InfRcTransportTest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/MasterService.h	View	2 chunks	+58 lines, -58 lines	0 comments	Download
M	src/MasterService.cc	View	43 chunks	+234 lines, -232 lines	0 comments	Download
M	src/MasterServiceTest.cc	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	src/MembershipService.h	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	src/MembershipService.cc	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	src/MockService.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/MockWrapper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/PingService.h	View	1 chunk	+13 lines, -13 lines	0 comments	Download
M	src/PingService.cc	View	5 chunks	+23 lines, -23 lines	0 comments	Download
M	src/ReplicatedSegmentTest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/RpcWrapper.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/Service.h	View	5 chunks	+19 lines, -19 lines	0 comments	Download
M	src/Service.cc	View	6 chunks	+13 lines, -13 lines	0 comments	Download
M	src/ServiceManager.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ServiceTest.cc	View	13 chunks	+20 lines, -20 lines	0 comments	Download