Issue 249001: Test - Code Review

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 249001: Test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by john.ousterhout

Modified:
6 years, 5 months ago

Reviewers:

Visibility:
Public.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1672 lines, -2285 lines)			Patch
M	src/CoordinatorMain.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/CoordinatorService.h	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	src/CoordinatorService.cc	View	7 chunks	+9 lines, -14 lines	0 comments	Download
M	src/CoordinatorServiceRecovery.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	src/CoordinatorServiceRecoveryTest.cc	View	2 chunks	+1 line, -42 lines	0 comments	Download
M	src/CoordinatorUpdateManager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	src/LargestTableId.proto	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	src/MakefragCoordinator	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/MakefragTest	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/MasterRecoveryManagerTest.cc	View	8 chunks	+31 lines, -40 lines	0 comments	Download
M	src/MasterServiceTest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/MockCluster.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/MockExternalStorage.h	View	2 chunks	+18 lines, -1 line	0 comments	Download
M	src/MockExternalStorage.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/MockService.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/RecoveryTest.cc	View	12 chunks	+35 lines, -39 lines	0 comments	Download
D	src/SplitTablet.proto	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	src/TableDrop.proto	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	src/TableInformation.proto	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	src/TableManager.h	View	5 chunks	+62 lines, -287 lines	0 comments	Download
M	src/TableManager.cc	View	7 chunks	+659 lines, -835 lines	0 comments	Download
M	src/TableManagerTest.cc	View	3 chunks	+824 lines, -776 lines	0 comments	Download
M	src/Tablet.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
D	src/TabletRecovered.proto	View	1 chunk	+0 lines, -46 lines	0 comments	Download