Issue 253221003: Homa

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 253221003: Homa

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 hours, 37 minutes ago by john.ousterhout

Modified:
4 hours, 37 minutes ago

Reviewers:

Visibility:
Public.

More Reviews

Description

Homa

Patch Set 1 #

Created: 4 hours, 37 minutes ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+766 lines, -866 lines)			Patch
M	Makefile	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	cloudlab/bin/update_linux	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cloudlab/update	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	homa_devel.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	homa_grant.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	homa_grant.c	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	homa_impl.h	View	6 chunks	+10 lines, -6 lines	0 comments	Download
M	homa_incoming.c	View	9 chunks	+8 lines, -15 lines	0 comments	Download
M	homa_metrics.c	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	homa_offload.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	homa_offload.c	View	10 chunks	+57 lines, -137 lines	0 comments	Download
M	homa_outgoing.c	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	homa_peer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	homa_peer.c	View	6 chunks	+14 lines, -10 lines	0 comments	Download
M	homa_plumbing.c	View	27 chunks	+23 lines, -36 lines	0 comments	Download
M	homa_qdisc.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	homa_qdisc.c	View	10 chunks	+13 lines, -13 lines	0 comments	Download
M	homa_rpc.c	View	2 chunks	+16 lines, -3 lines	0 comments	Download
M	homa_skb.c	View	6 chunks	+21 lines, -7 lines	0 comments	Download
M	homa_wire.h	View	3 chunks	+6 lines, -8 lines	0 comments	Download
M	murmurhash3.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	notes.txt	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	test/Makefile	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/mock.h	View	4 chunks	+7 lines, -8 lines	0 comments	Download
M	test/mock.c	View	41 chunks	+85 lines, -150 lines	0 comments	Download
M	test/rbtree.c	View	16 chunks	+87 lines, -8 lines	0 comments	Download
M	test/rhashtable.c	View	40 chunks	+184 lines, -179 lines	0 comments	Download
M	test/unit_homa_incoming.c	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	test/unit_homa_offload.c	View	17 chunks	+114 lines, -164 lines	0 comments	Download
M	test/unit_homa_outgoing.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/unit_homa_peer.c	View	6 chunks	+8 lines, -9 lines	0 comments	Download
M	test/unit_homa_plumbing.c	View	34 chunks	+38 lines, -54 lines	0 comments	Download
M	test/unit_homa_rpc.c	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	test/unit_homa_skb.c	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	test/unit_homa_sock.c	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	timetrace.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	timetrace.c	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	util/strip_decl.py	View	1 chunk	+0 lines, -1 line	0 comments	Download