Issue 311001: Precommit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 311001: Precommit (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by john.ousterhout

Modified:
5 years, 8 months ago

Reviewers:

Visibility:
Public.

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2202 lines, -2140 lines)			Patch
M	src/Context.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/CoordinatorMain.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/CoordinatorServerList.h	View	15 chunks	+104 lines, -165 lines	0 comments	Download
M	src/CoordinatorServerList.cc	View	33 chunks	+606 lines, -622 lines	0 comments	Download
M	src/CoordinatorServerListTest.cc	View	8 chunks	+1249 lines, -1135 lines	0 comments	Download
M	src/CoordinatorService.cc	View	3 chunks	+23 lines, -7 lines	0 comments	Download
M	src/CoordinatorServiceTest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/CoordinatorUpdateManager.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/CoordinatorUpdateManager.cc	View	2 chunks	+16 lines, -1 line	0 comments	Download
M	src/MakefragCoordinator	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/MasterRecoveryManagerTest.cc	View	15 chunks	+37 lines, -41 lines	0 comments	Download
M	src/MembershipService.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/MembershipServiceTest.cc	View	8 chunks	+34 lines, -27 lines	0 comments	Download
M	src/ServerList.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/ServerList.cc	View	5 chunks	+31 lines, -35 lines	0 comments	Download
M	src/ServerList.proto	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/ServerListTest.cc	View	2 chunks	+40 lines, -78 lines	0 comments	Download
M	src/ServerTest.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/ServerTracker.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/TableManager.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/Tablet.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/TabletTest.cc	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	src/TestUtil.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/TestUtil.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/WireFormat.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download